-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT(client): Drop the version from window title #5164
FEAT(client): Drop the version from window title #5164
Conversation
Please don't check checkboxes blindly. Your commit does not follow the commit guidelines at all. Please fix that (I would consider this to be of TYPE As for the translations: You can update them yourself. After having fixed your commit, run |
c09ba3b
to
491a20e
Compare
That script does not run:
|
Are you perhaps using Python 2 instead of 3? |
Having the release number is rather non-standard behavior (see mumble-voip#1260), but it is also particularly annoying for visually-impaired users who, every time they Alt-Tab into the Mumble window, have to listen to the quite lengthy digit sequence (which may get even worse with distro-issued builds: the current window title in Debian stable is "Mumble -- 1.3.0~git20190125.440b173+dfsg-2"; now try reading that out loud and imagine hearing it multiple times in a row!...).
491a20e
to
f319622
Compare
I ran the translation script and also changed your commit message's title a bit. |
Thank you for your contribution 👍 |
Having the release number is rather non-standard behavior
(see #1260 and comments), but it is also particularly annoying
for visually-impaired users who, everytime they Alt-Tab into
the Mumble window, have to listen to the quite lenghthy
digit sequence (which may get even worse with distro-issued
builds: the current window title in Debian stable is
"Mumble -- 1.3.0~git20190125.440b173+dfsg-2"; now try
reading that out loud and imagine hearing it multiple times
in a row!...).
The Transifex bot will need to be run if this gets merged.
Checks