Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT(client): Drop the version from window title #5164

Merged

Conversation

vvillenave
Copy link

Having the release number is rather non-standard behavior
(see #1260 and comments), but it is also particularly annoying
for visually-impaired users who, everytime they Alt-Tab into
the Mumble window, have to listen to the quite lenghthy
digit sequence (which may get even worse with distro-issued
builds: the current window title in Debian stable is
"Mumble -- 1.3.0~git20190125.440b173+dfsg-2"; now try
reading that out loud and imagine hearing it multiple times
in a row!...).

The Transifex bot will need to be run if this gets merged.

Checks

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jul 6, 2021

My commits follow the commit guidelines

Please don't check checkboxes blindly. Your commit does not follow the commit guidelines at all. Please fix that (I would consider this to be of TYPE FEAT).

As for the translations: You can update them yourself. After having fixed your commit, run scripts/updatetranslations.py and that will take care of adding a separate commit that will update the translation files for you.

@Krzmbrzl Krzmbrzl added accessibility Everything related to accessibility-features (like screen-readers) client feature-request This issue or PR deals with a new feature labels Jul 6, 2021
@vvillenave vvillenave force-pushed the drop-releasenumber-from-titlebar branch from c09ba3b to 491a20e Compare July 6, 2021 10:23
@vvillenave
Copy link
Author

That script does not run:

  File "./scripts/updatetranslations.py", line 138, in <module>
    (resnsrc, resnnew, resnsame) = Update(lupdatebin, tsfile, args.debuglupdate, applyHeuristics = not args.ci_mode)
  File "./scripts/updatetranslations.py", line 87, in Update
    logging.debug('stdout: ' + res.stdout)
TypeError: can only concatenate str (not "bytes") to str

@davidebeatrici
Copy link
Member

Are you perhaps using Python 2 instead of 3?

Valentin Villenave and others added 2 commits July 7, 2021 08:07
Having the release number is rather non-standard behavior
(see mumble-voip#1260), but it is also particularly annoying for
visually-impaired users who, every time they Alt-Tab into
the Mumble window, have to listen to the quite lengthy
digit sequence (which may get even worse with distro-issued
builds: the current window title in Debian stable is
"Mumble -- 1.3.0~git20190125.440b173+dfsg-2"; now try
reading that out loud and imagine hearing it multiple times
in a row!...).
@Krzmbrzl Krzmbrzl force-pushed the drop-releasenumber-from-titlebar branch from 491a20e to f319622 Compare July 7, 2021 06:09
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jul 7, 2021

I ran the translation script and also changed your commit message's title a bit.

@Krzmbrzl Krzmbrzl changed the title Title Bar: drop the release number FEAT(client): Drop the version from window title Jul 7, 2021
@Krzmbrzl Krzmbrzl merged commit abc4f7d into mumble-voip:master Jul 7, 2021
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Jul 7, 2021

Thank you for your contribution 👍

@Hartmnt Hartmnt added the a11y label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Everything related to accessibility-features (like screen-readers) client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants