Use value parameter for unjailing nodes #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -241,7 +241,7 @@ def install(self, overwrite: bool) -> None: | |||
| self._install_sc_meta() | |||
| self._install_wasm_opt() | |||
| self._install_twiggy() | |||
| self._install_sc_meta_deps() | |||
| show_message("Please also install all the necessary dependencies required for `sc-meta` to run properly bu running the following command: `sc-meta install all`.") | |||
|
|
||
| tx = self._factory.create_transaction_for_unjailing_nodes( | ||
| sender=owner.address, | ||
| delegation_contract=delegation_contract, | ||
| public_keys=public_keys | ||
| public_keys=public_keys, | ||
| amount=amount |
There was a problem hiding this comment.
Should have been a separate PR from the one that alters sc-meta installation flow.
There was a problem hiding this comment.
I'll move the alteration of sc-meta in another PR.
| @@ -241,7 +241,7 @@ def install(self, overwrite: bool) -> None: | |||
| self._install_sc_meta() | |||
| self._install_wasm_opt() | |||
| self._install_twiggy() | |||
| self._install_sc_meta_deps() | |||
| show_message("Please also install all the necessary dependencies required for `sc-meta` to run properly bu running the following command: `sc-meta install all`.") | |||
There was a problem hiding this comment.
Should have been a separate PR from the one adjusting the amount for unjailing (for changelog / release note purposes).
andreibancioiu
approved these changes
Sep 18, 2024
danidrasovean
approved these changes
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now setting value on transaction when unjailing nodes.