Localnet: compatibility with Node 1.7 (Vega) #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
popenta
previously approved these changes
May 13, 2024
andreibancioiu
commented
May 27, 2024
Comment on lines
+67
to
+70
| max_nodes_change_enable_epoch = enable_epochs['MaxNodesChangeEnableEpoch'] | ||
| last_entry = max_nodes_change_enable_epoch[-1] | ||
| penultimate_entry = max_nodes_change_enable_epoch[-2] | ||
| last_entry['MaxNumNodes'] = penultimate_entry['MaxNumNodes'] - (config.shards.num_shards + 1) * penultimate_entry['NodesToShufflePerShard'] |
popenta
approved these changes
May 27, 2024
ovidiuolteanu
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
mxpy localnetcompatible with Vega release.Simplification of
genesis.json: no more legacy delegationSimplification - no more legacy delegation. E.g. (excerpt from
genesis.json):Simplification of config patching -
enableEpochs.tomlSimplification -
enableEpochs.tomlentries are only minimally adjusted now (they were heavily adjusted before). All feature flags now correspond to:enableEpochs.toml.Some implications (can lead to breaking changes in using
mxpy localnet):SCDeployEnableEpochis 1 (default of mx-chain-go repository) instead of 0 (previous default in mxpy)ESDTEnableEpochis 1 (default of mx-chain-go repository) instead of 0 (previous default in mxpy)