Skip to content

Fixed ledger signing #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 8, 2025
Merged

Fixed ledger signing #152

merged 10 commits into from
May 8, 2025
+35 −14

Conversation

razvantomegea
Copy link
Contributor

Issue

  • Side panel is not closed on rejection / error
  • Sign button is not disabled and no relevant message is shown during transaction signing

Fix

  • Close panel on error / reject
  • Show Confirm on Ledger during signinig

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@MiroMargineanu MiroMargineanu added the bug Something isn't working label May 2, 2025
@razvantomegea razvantomegea merged commit 467df52 into development May 8, 2025
1 check passed
@razvantomegea razvantomegea deleted the rt/fix/ledger-signing branch May 8, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhtudormorar arhtudormorar arhtudormorar left review comments

@MiroMargineanu MiroMargineanu MiroMargineanu approved these changes

Assignees

@razvantomegea razvantomegea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvantomegea @arhtudormorar @MiroMargineanu