Skip to content

Fixed sign transactions button states #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Fixed sign transactions button states #87

merged 2 commits into from
May 5, 2025

Conversation

razvantomegea
Copy link
Contributor

Issue

  • Sign button is not disabled during signing
  • No relevant meesage is shown during signing
  • Nothing is shown during signing
  • Text is black on black background

Fix

  • Show Confirm on PROVIDER during signing and disable the button
  • Make text white
  • Fixed incorrect sign transaction components tag names

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@MiroMargineanu MiroMargineanu added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 2, 2025
@razvantomegea razvantomegea merged commit 75d3cf6 into development May 5, 2025
2 checks passed
@razvantomegea razvantomegea deleted the rt/fix/sign-transaction-button-state branch May 5, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhtudormorar arhtudormorar arhtudormorar approved these changes

@MiroMargineanu MiroMargineanu MiroMargineanu approved these changes

Assignees

@razvantomegea razvantomegea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvantomegea @arhtudormorar @MiroMargineanu