Pre-processing improvements #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ssd04
commented
Feb 6, 2024
•
ssd04
commented
- cleanup old code
- move events logic from facade to eventsHandler
- return early if duplicated event
This reverts commit 0be9123.
| "block hash", events.Hash, | ||
| pushEvents := data.BlockEvents{ | ||
| Hash: eventsData.Hash, | ||
| ShardID: eventsData.Header.GetShardID(), |
There was a problem hiding this comment.
is there any chance here to have the header nil, resulting in a panic?
There was a problem hiding this comment.
no, there is a header check in events interceptor
| @@ -252,29 +280,16 @@ func (eh *eventsHandler) HandleBlockScrs(blockScrs data.BlockScrs) { | |||
| } | |||
|
|
|||
| // HandleBlockEventsWithOrder will handle full block events received from observer | |||
| func (eh *eventsHandler) HandleBlockEventsWithOrder(blockTxs data.BlockEventsWithOrder) { | |||
| func (eh *eventsHandler) handleBlockEventsWithOrder(blockTxs data.BlockEventsWithOrder) { | |||
There was a problem hiding this comment.
update comment with lower case
| @@ -715,6 +715,6 @@ func testNotifierWithWebsockets_AllEvents(t *testing.T, observerType string) { | |||
|
|
|||
| integrationTests.WaitTimeout(t, wg, time.Second*4) | |||
|
|
|||
| assert.Equal(t, numEvents, len(notifier.RedisClient.GetEntries())) | |||
| assert.Equal(t, numEvents, len(notifier.RedisClient.GetEntries())) | |||
| expectedNumRedisEvents := 3 // one redis events per push, revert, finalized | |||
There was a problem hiding this comment.
Suggested change
| expectedNumRedisEvents := 3 // one redis events per push, revert, finalized | |
| expectedNumRedisEvents := 3 // one redis event per push, revert, finalized |
| @@ -10,8 +10,7 @@ import ( | |||
|
|
|||
| // EventsFacadeHandler defines the behavior of a facade handler needed for events group | |||
| type EventsFacadeHandler interface { | |||
| HandlePushEventsV2(events data.ArgsSaveBlockData) error | |||
| HandlePushEventsV1(events data.SaveBlockData) error | |||
| HandlePushEvents(events data.ArgsSaveBlockData) error | |||
sstanculeanu
approved these changes
Feb 16, 2024
iulianpascalau
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.