Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring metrics and additional logging #76

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Monitoring metrics and additional logging #76

merged 8 commits into from
Aug 11, 2023

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Aug 9, 2023 •
edited
Loading

Added more expliocit logging for rabbitmq and redis integrations.
Monitoring metrics for redis and rabbitmq operations.

@ssd04 ssd04 self-assigned this Aug 9, 2023
@ssd04 ssd04 changed the title events handler logging improvements Monitoring metrics and additional logging Aug 9, 2023
@ssd04 ssd04 marked this pull request as ready for review August 9, 2023 11:43
bogdan-rosianu
bogdan-rosianu reviewed Aug 9, 2023
View reviewed changes
api/groups/statusGroup.go Outdated Show resolved Hide resolved
api/groups/statusGroup.go Outdated Show resolved Hide resolved
api/groups/statusGroup.go Outdated Show resolved Hide resolved
metrics/statusMetrics_test.go Show resolved Hide resolved
rabbitmq/rabbitClient.go Show resolved Hide resolved
redis/connection.go Outdated Show resolved Hide resolved
bogdan-rosianu
bogdan-rosianu previously approved these changes Aug 11, 2023
View reviewed changes
miiu96
miiu96 reviewed Aug 11, 2023
View reviewed changes
Copy link

@miiu96 miiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can extract all the API endpoints in a config file, this can be done in a future PR

miiu96
miiu96 previously approved these changes Aug 11, 2023
View reviewed changes
@ssd04 ssd04 changed the base branch from main to feat/monitoring-metrics August 11, 2023 08:02
@ssd04 ssd04 dismissed stale reviews from miiu96 and bogdan-rosianu August 11, 2023 08:02

The base branch was changed.

@ssd04 ssd04 merged commit 0a17f10 into feat/monitoring-metrics Aug 11, 2023
2 checks passed
@ssd04 ssd04 deleted the rabbitmq-reconnect-and-logging branch August 11, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miiu96 miiu96 miiu96 approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@ssd04 ssd04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssd04 @miiu96 @bogdan-rosianu