Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil event fields #103

Merged
merged 3 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions integrationTests/websocket/testNotifierWithWebsockets_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ func TestNotifierWithWebsockets_PushEvents(t *testing.T) {
{
Address: hex.EncodeToString(addr),
TxHash: "txHash1",
Data: make([]byte, 0),
Topics: make([][]byte, 0),
},
}

Expand Down Expand Up @@ -135,6 +137,8 @@ func TestNotifierWithWebsockets_BlockEvents(t *testing.T) {
{
Address: hex.EncodeToString(addr),
TxHash: "txHash1",
Data: make([]byte, 0),
Topics: make([][]byte, 0),
},
}
expBlockEvents := &data.BlockEventsWithOrder{
Expand Down Expand Up @@ -559,6 +563,8 @@ func testNotifierWithWebsockets_AllEvents(t *testing.T, observerType string) {
events := []data.Event{
{
Address: hex.EncodeToString(addr),
Data: make([]byte, 0),
Topics: make([][]byte, 0),
},
}

Expand Down
16 changes: 13 additions & 3 deletions process/eventsInterceptor.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (ei *eventsInterceptor) getLogEventsFromTransactionsPool(logs []*outport.Lo
}

if len(logEvents) == 0 {
return nil
return make([]data.Event, 0)
}

events := make([]data.Event, 0, len(logEvents))
Expand All @@ -122,11 +122,21 @@ func (ei *eventsInterceptor) getLogEventsFromTransactionsPool(logs []*outport.Lo
"identifier", eventIdentifier,
)

topics := event.EventHandler.GetTopics()
if topics == nil {
topics = make([][]byte, 0)
}

eventData := event.EventHandler.GetData()
if eventData == nil {
eventData = make([]byte, 0)
}

events = append(events, data.Event{
Address: bech32Address,
Identifier: eventIdentifier,
Topics: event.EventHandler.GetTopics(),
Data: event.EventHandler.GetData(),
Topics: topics,
Data: eventData,
TxHash: event.TxHash,
})
}
Expand Down
70 changes: 69 additions & 1 deletion process/eventsInterceptor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ func TestProcessBlockEvents(t *testing.T) {
ScrsWithOrder: expScrsWithOrder,
LogEvents: []data.Event{
{
Address: hex.EncodeToString(addr),
Address: hex.EncodeToString(addr),
Identifier: "",
Data: make([]byte, 0),
Topics: make([][]byte, 0),
},
},
}
Expand All @@ -205,6 +208,71 @@ func TestProcessBlockEvents(t *testing.T) {
require.Nil(t, err)
require.Equal(t, expEvents, events)
})

t.Run("nil event fields should be returned as empty", func(t *testing.T) {
t.Parallel()

eventsInterceptor, _ := process.NewEventsInterceptor(createMockEventsInterceptorArgs())

addr := []byte("addr1")

blockBody := &block.Body{
MiniBlocks: make([]*block.MiniBlock, 1),
}
blockHeader := &block.HeaderV2{
Header: &block.Header{
ShardID: 1,
TimeStamp: 1234,
},
}

logs := []*outport.LogData{
{
Log: &transaction.Log{
Address: addr,
Events: []*transaction.Event{
{
Address: addr,
Topics: nil,
Data: nil,
Identifier: nil,
},
},
},
},
}

blockHash := []byte("blockHash")
blockEvents := data.ArgsSaveBlockData{
HeaderHash: blockHash,
Body: blockBody,
Header: blockHeader,
TransactionsPool: &outport.TransactionPool{
Logs: logs,
},
}

expEvents := &data.InterceptorBlockData{
Hash: hex.EncodeToString(blockHash),
Body: blockBody,
Header: blockHeader,
Txs: make(map[string]*transaction.Transaction),
Scrs: make(map[string]*smartContractResult.SmartContractResult),
LogEvents: []data.Event{
{
Address: hex.EncodeToString(addr),
Identifier: "",
Data: make([]byte, 0),
Topics: make([][]byte, 0),
},
},
}

events, err := eventsInterceptor.ProcessBlockEvents(&blockEvents)
require.Nil(t, err)
require.Equal(t, expEvents, events)
})

}

func TestGetLogEventsFromTransactionsPool(t *testing.T) {
Expand Down
Loading