FIX: Pointer receiver in OutGoingMiniBlockHeaders slice

multiversx · Feb 11, 2025 · 8998ffb · 8998ffb
1 parent 065d378
commit 8998ffb
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 80 deletions.
diff --git a/data/block/sovereignChainHeader.go b/data/block/sovereignChainHeader.go
@@ -42,7 +42,7 @@ func (sch *SovereignChainHeader) ShallowClone() data.HeaderHandler {
 	headerCopy.Header = &internalHeaderCopy
 
 	if len(sch.OutGoingMiniBlockHeaders) != 0 {
-		headerCopy.OutGoingMiniBlockHeaders = make([]OutGoingMiniBlockHeader, len(sch.OutGoingMiniBlockHeaders))
+		headerCopy.OutGoingMiniBlockHeaders = make([]*OutGoingMiniBlockHeader, len(sch.OutGoingMiniBlockHeaders))
 		copy(headerCopy.OutGoingMiniBlockHeaders, sch.OutGoingMiniBlockHeaders)
 	}
 
@@ -558,7 +558,7 @@ func (sch *SovereignChainHeader) GetOutGoingMiniBlockHeaderHandlers() []data.Out
 	mbHeaderHandlers := make([]data.OutGoingMiniBlockHeaderHandler, len(mbHeaders))
 
 	for i := range mbHeaders {
-		mbHeaderHandlers[i] = &mbHeaders[i]
+		mbHeaderHandlers[i] = mbHeaders[i]
 	}
 
 	return mbHeaderHandlers
@@ -572,7 +572,7 @@ func (sch *SovereignChainHeader) GetOutGoingMiniBlockHeaderHandler(mbType int32)
 
 	for _, outGoingMbHdr := range sch.OutGoingMiniBlockHeaders {
 		if int32(outGoingMbHdr.OutGoingMBType) == mbType {
-			return &outGoingMbHdr
+			return outGoingMbHdr
 		}
 	}
 
@@ -598,8 +598,8 @@ func (sch *SovereignChainHeader) SetOutGoingMiniBlockHeaderHandler(mbHeader data
 	return nil
 }
 
-func createOutGoingMbHeader(mbHeader data.OutGoingMiniBlockHeaderHandler) OutGoingMiniBlockHeader {
-	return OutGoingMiniBlockHeader{
+func createOutGoingMbHeader(mbHeader data.OutGoingMiniBlockHeaderHandler) *OutGoingMiniBlockHeader {
+	return &OutGoingMiniBlockHeader{
 		OutGoingMBType:                        OutGoingMBType(mbHeader.GetOutGoingMBTypeInt32()),
 		Hash:                                  mbHeader.GetHash(),
 		OutGoingOperationsHash:                mbHeader.GetOutGoingOperationsHash(),
@@ -619,7 +619,7 @@ func (sch *SovereignChainHeader) SetOutGoingMiniBlockHeaderHandlers(mbHeaders []
 		return nil
 	}
 
-	miniBlockHeaders := make([]OutGoingMiniBlockHeader, len(mbHeaders))
+	miniBlockHeaders := make([]*OutGoingMiniBlockHeader, len(mbHeaders))
 	for i, mbHeaderHandler := range mbHeaders {
 		miniBlockHeaders[i] = createOutGoingMbHeader(mbHeaderHandler)
 	}

diff --git a/data/block/sovereignChainHeader.pb.go b/data/block/sovereignChainHeader.pb.go
diff --git a/data/block/sovereignChainHeader.proto b/data/block/sovereignChainHeader.proto
@@ -30,7 +30,7 @@ message SovereignChainHeader {
   Header                           Header                    = 1 [(gogoproto.jsontag) = "header"];
   bytes                            ValidatorStatsRootHash    = 2 [(gogoproto.jsontag) = "validatorStatsRootHash"];
   repeated bytes                   ExtendedShardHeaderHashes = 3 [(gogoproto.jsontag) = "extendedShardHeaderHashes,omitempty"];
-  repeated OutGoingMiniBlockHeader OutGoingMiniBlockHeaders  = 4 [(gogoproto.jsontag) = "outGoingOperations,omitempty", (gogoproto.nullable) = false];
+  repeated OutGoingMiniBlockHeader OutGoingMiniBlockHeaders  = 4 [(gogoproto.jsontag) = "outGoingOperations,omitempty"];
   bool                             IsStartOfEpoch            = 5 [(gogoproto.jsontag) = "isStartOfEpoch,omitempty"];
   bytes                            AccumulatedFeesInEpoch    = 6 [(gogoproto.jsontag) = "accumulatedFeesInEpoch,omitempty", (gogoproto.casttypewith) = "math/big.Int;github.com/multiversx/mx-chain-core-go/data.BigIntCaster"];
   bytes                            DevFeesInEpoch            = 7 [(gogoproto.jsontag) = "devFeesInEpoch,omitempty", (gogoproto.casttypewith) = "math/big.Int;github.com/multiversx/mx-chain-core-go/data.BigIntCaster"];