-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export NFT/SFT/MetaESDT hash field #1449
Conversation
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
src/endpoints/nfts/nft.service.ts
Outdated
@@ -349,6 +348,7 @@ export class NftService { | |||
const elasticNftData = elasticNft.data; | |||
if (elasticNftData) { | |||
nft.name = elasticNftData.name; | |||
nft.hash = nft.hash = TokenHelpers.getNftProof(elasticNftData.hash) || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nft.hash = nft.hash = ... (typo)
Is it intended to use '||' instead of '??' considering that getNftProof
returns string | undefined ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. fixed
a471a95
Reasoning
hash
field of NFTs/SFTs/MetaESDTs was not reflected on the APIProposed Changes
hash
field as wellHow to test