Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export NFT/SFT/MetaESDT hash field #1449

Merged
merged 9 commits into from
Mar 4, 2025

Conversation

bogdan-rosianu
Copy link
Contributor

@bogdan-rosianu bogdan-rosianu commented Feb 12, 2025

Reasoning

  • the hash field of NFTs/SFTs/MetaESDTs was not reflected on the API

Proposed Changes

  • return hash field as well

How to test

@bogdan-rosianu bogdan-rosianu self-assigned this Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

k6 load testing comparison.
Base Commit Hash: 887bd0b
Target Commit Hash: a471a95

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Accounts50.15878.9853.5855.4851.061045.5354.7856.34+1.82% 🔴+18.95% 🔴+2.23% 🔴+1.55% 🔴
Mex49.42683.3453.5055.3250.43617.6154.8056.91+2.06% 🔴-9.62% ✅+2.42% 🔴+2.88% 🔴
Transactions66.832355.8954.2857.3368.552502.5855.9158.88+2.58% 🔴+6.23% 🔴+3.01% 🔴+2.71% 🔴
Blocks55.521221.6754.1456.8056.371130.1955.4058.39+1.53% 🔴-7.49% ✅+2.32% 🔴+2.81% 🔴
Nodes49.36396.0053.4655.2751.111126.3054.6156.42+3.53% 🔴+184.42% 🔴+2.14% 🔴+2.09% 🔴
Pool49.52550.0253.5155.2650.49654.7954.8456.65+1.96% 🔴+19.05% 🔴+2.48% 🔴+2.51% 🔴
Tokens49.68646.1853.5155.2250.62714.9454.8156.52+1.88% 🔴+10.64% 🔴+2.42% 🔴+2.35% 🔴
Test Run Duration60003.2060002.06

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu marked this pull request as ready for review February 26, 2025 09:30
cfaur09
cfaur09 previously approved these changes Feb 26, 2025
@@ -349,6 +348,7 @@ export class NftService {
const elasticNftData = elasticNft.data;
if (elasticNftData) {
nft.name = elasticNftData.name;
nft.hash = nft.hash = TokenHelpers.getNftProof(elasticNftData.hash) || '';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nft.hash = nft.hash = ... (typo)
Is it intended to use '||' instead of '??' considering that getNftProof returns string | undefined ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed

GuticaStefan
GuticaStefan previously approved these changes Mar 4, 2025
gabrielmatei
gabrielmatei previously approved these changes Mar 4, 2025
@bogdan-rosianu bogdan-rosianu dismissed stale reviews from gabrielmatei and GuticaStefan via a471a95 March 4, 2025 14:06
@bogdan-rosianu bogdan-rosianu merged commit c5eca22 into development Mar 4, 2025
6 checks passed
@bogdan-rosianu bogdan-rosianu deleted the add-first-proof-support branch March 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants