Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts deploys endpoints #1336

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Sep 19, 2024

Proposed Changes

  • for the <api>/accounts/:address/deploys -> use deployer for the elastic query match
  • for the <api>/accounts/:address/contracts -> use currentOwner for the elastic query match

How to test

  • <api>/accounts/erd1ss6u80ruas2phpmr82r42xnkd6rxy40g9jl69frppl4qez9w2jpsqj8x97/deploys -> should return only the deploys that the given address has been made
  • <api>/accounts/erd1ss6u80ruas2phpmr82r42xnkd6rxy40g9jl69frppl4qez9w2jpsqj8x97/contracts -> should return only the contracts where the given address is owner
  • <api>/accounts/erd1ss6u80ruas2phpmr82r42xnkd6rxy40g9jl69frppl4qez9w2jpsqj8x97/deploys/count -> should return only the deploys count that the given address has been made ( ±71 )
  • <api>/accounts/erd1ss6u80ruas2phpmr82r42xnkd6rxy40g9jl69frppl4qez9w2jpsqj8x97/contracts/count -> should return only the contracts count where the given address is owner ( ±20)

@cfaur09 cfaur09 added refactoring The same functionality is maintained, but in an improved way feature New feature or request labels Sep 19, 2024
@cfaur09 cfaur09 self-assigned this Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

k6 load testing comparison.
Base Commit Hash: e409dd6
Target Commit Hash: e9a536b

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Tokens48.69536.6756.8362.9850.51400.5356.6864.93+3.74% 🔴-25.37% ✅-0.26% ✅+3.10% 🔴
Blocks54.661170.4957.8465.3857.501195.3459.1266.44+5.20% 🔴+2.12% 🔴+2.21% 🔴+1.62% 🔴
Nodes48.43302.4756.8363.0051.561231.7056.7664.55+6.46% 🔴+307.22% 🔴-0.11% ✅+2.46% 🔴
Accounts48.91513.2756.8363.3351.15805.6856.8264.86+4.58% 🔴+56.97% 🔴-0.03% ✅+2.41% 🔴
Pool48.44317.9556.8463.0250.68629.4356.8364.92+4.63% 🔴+97.97% 🔴-0.03% ✅+3.02% 🔴
Mex48.22293.2656.4762.9850.04180.0356.6464.72+3.77% 🔴-38.61% ✅+0.29% 🔴+2.77% 🔴
Transactions61.741867.7259.0765.0364.001869.0356.5264.94+3.65% 🔴+0.07% 🔴-4.32% ✅-0.15% ✅
Test Run Duration60002.5660006.96

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@tanghel tanghel merged commit 081bd5a into development Oct 8, 2024
4 checks passed
@tanghel tanghel deleted the SERVICES-2598-contracts-deploys-endpoints branch October 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactoring The same functionality is maintained, but in an improved way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants