Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodes fetch from external api unit tests #1330

Merged

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Sep 11, 2024

Reasoning

  • no testcase implemented for the case when isNodesFetchFeatureEnabled is false

Proposed Changes

  • create new unit test for the getAllNodes when isNodesFetchFeatureEnabled is false
  • adjust also the unit test for the getAllNodes when isNodesFetchFeatureEnabled is true

How to test

  • npm run test nodes.spec.ts

@cfaur09 cfaur09 self-assigned this Sep 11, 2024
@cfaur09 cfaur09 added the test Create or update unit / integration tests label Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

k6 load testing comparison.
Base Commit Hash: cce46d1
Target Commit Hash: 92629c7

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes50.211026.7954.1462.0050.401119.4653.9760.56+0.38% 🔴+9.02% 🔴-0.31% ✅-2.32% ✅
Tokens50.07817.8554.1962.3549.46287.0353.9761.08-1.22% ✅-64.90% ✅-0.41% ✅-2.03% ✅
Pool49.88544.3654.3962.1350.16876.0554.0060.99+0.56% 🔴+60.93% 🔴-0.72% ✅-1.84% ✅
Transactions62.221005.2757.0767.6961.531018.9555.7666.58-1.10% ✅+1.36% 🔴-2.31% ✅-1.65% ✅
Mex49.28215.2454.5561.4549.87622.4753.9760.93+1.20% 🔴+189.20% 🔴-1.07% ✅-0.85% ✅
Blocks56.071381.4655.2566.1755.691578.9654.4762.88-0.69% ✅+14.30% 🔴-1.42% ✅-4.98% ✅
Accounts49.53236.7554.1762.1949.85584.5054.0061.13+0.64% 🔴+146.88% 🔴-0.31% ✅-1.71% ✅
Test Run Duration60007.6660003.19

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 merged commit b2ed900 into development Sep 11, 2024
5 checks passed
@cfaur09 cfaur09 deleted the SERVICES-2580-nodes-fetch-from-external-api-unit-tests branch September 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Create or update unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants