Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor] Fix duplicate map meta entries resulting in editor suspending. #543

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

chris1384
Copy link
Contributor

Fixes #538

Screenshot_24

This does not check for multiple files with different attributes (ex. scripts type that use both client and server instead of shared).

@jlillis
Copy link
Contributor

jlillis commented Sep 1, 2024

I'm not sure ignoring duplicate entries is the best idea - there should a warning shown to the user informing them of the issue. If editor is duplicating files that means there is a bug that needs to be fixed.

@chris1384
Copy link
Contributor Author

dup

The editor does exactly what the map meta contains, but it fails at fileCopy if there's a file already copied.
I wouldn't say that the editor is at fault here, it's either the users fault or an another resource with general.ModifyOtherObjects permissions and writes extra lines in the meta. I can't think of a better approach for this so feel free to suggest anything. :d

@jlillis
Copy link
Contributor

jlillis commented Sep 4, 2024

I wouldn't say that the editor is at fault here, it's either the users fault or an another resource with general.ModifyOtherObjects permissions and writes extra lines in the meta.

I think you're probably right. If this breaks anything at least we'll have a debug warning to trace it with.

@jlillis jlillis merged commit b64e5b4 into multitheftauto:master Sep 4, 2024
1 check passed
@chris1384 chris1384 deleted the dupmeta-fix branch September 4, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Duplicate the same filename in meta.xml causes editor to stop
2 participants