Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeroam: fix freezetime flickering #529 #530

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

ricksterhd123
Copy link
Contributor

@ricksterhd123 ricksterhd123 commented Aug 2, 2024

resolves #529

Uses the max value of setMinuteDuration, so in theory 1 minute should just under 25 days.

Fixes the flickering, removes redundant timer and its 3 variables, in mtasa-resources freeroam weather is always static (correct me if I'm wrong), weather should be separate from freeze time.

Note: I can go back and use feature branch on my fork, this was purely accidental, my bad

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, setMinuteDuration works fine this way. LGTM

@ricksterhd123 ricksterhd123 changed the title fix freezetime flickering #529 freeroam: fix freezetime flickering #529 Aug 2, 2024
@ricksterhd123 ricksterhd123 marked this pull request as ready for review August 2, 2024 00:29
@jlillis
Copy link
Contributor

jlillis commented Aug 6, 2024

Given the original issue is just cosmetic, maybe this could wait until multitheftauto/mtasa-blue#3567 is merged and use setTimeFrozen instead?

@ricksterhd123
Copy link
Contributor Author

ricksterhd123 commented Aug 6, 2024

Given the original issue is just cosmetic, maybe this could wait until multitheftauto/mtasa-blue#3567 is merged and use setTimeFrozen instead?

No rush, please can you ping me once it's been merged and in the next update

*edit: feel free to do this yourself I think the diff mainly removing the old code

@jlillis
Copy link
Contributor

jlillis commented Aug 22, 2024

@ricksterhd123 multitheftauto/mtasa-blue#3567 is merged into nightly, feel free to update PR when able. Don't forget to update min_mta_version.

@jlillis
Copy link
Contributor

jlillis commented Sep 1, 2024

I'm going to make the setMinuteDuration -> setMinuteFrozen change in a follow-up PR.

@jlillis jlillis merged commit b40f27b into multitheftauto:master Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freeroam freezetime causes slightly noticible screen flickering every 5 seconds
3 participants