Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic security resource as a foundation #528

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

ffsPLASMA
Copy link
Contributor

@ffsPLASMA ffsPLASMA commented Jul 29, 2024

As the notes say, this resource aims to be a barebone security foundation for server owners to enhance and adapt on for their personal gamemodes. As recent times showed, security needs to be highlighted more and this resource should give a base start point for developers to work on. It only covers the most basic events and logs them.

@Fernando-A-Rocha
Copy link
Contributor

You are basically implementing these principles
https://wiki.multitheftauto.com/wiki/Script_security

@Fernando-A-Rocha
Copy link
Contributor

I suggested this on mta dev discord and people discussed it. Some said it is not enough to make a server secure, that is correct, it's a foundation as PLASMA stated here in this PR. I believe it makes sense to have this resource in the default resources pack. It's essential nowadays on all servers.

@Fernando-A-Rocha
Copy link
Contributor

@ffsPLASMA
Copy link
Contributor Author

Yes its not a solution to cheating, nor should it be considered. its just a base with some useful events to catch potential abusive players and build upon it. I always wondered why nothing of such sorts were included by default.

[admin]/security/logging.lua Outdated Show resolved Hide resolved
[admin]/security/logging.lua Outdated Show resolved Hide resolved
[admin]/security/logging.lua Show resolved Hide resolved
[admin]/security/players.lua Show resolved Hide resolved
Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the intent here but I really don't see this as a useful resource. If all it is doing is logging potentially problematic behavior. For this to be useful, it should really be integrated into admin/admin2 and take some action by default.

@Dutchman101
Copy link
Member

I get the intent here but I really don't see this as a useful resource. If all it is doing is logging potentially problematic behavior. For this to be useful, it should really be integrated into admin/admin2 and take some action by default.

This is just the beginning, after we see results from varying servers and gamemodes, the logging sensitivity may be tweaked to the point it's suitable for violation to lead to an action (or specific violation subtypes, definable by the server owner, as appropiate for their gamemode). Also, if we add universal, generic security checks that aren't mainly to raise an alert but to make a certain cheat effect impossible or violate on it, the code will grow expotentially as well as it will do down the line anyways, as again this is a very early version and there's much more to do here; it's better in a dedicated resource than bloating admin, or having to mind its structure when expanding it.

Really more of a "good to have, why not" thing at this point, and it can become really of value as it gets expanded to cover way more types of things.

@Dutchman101 Dutchman101 merged commit 5569832 into multitheftauto:master Aug 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants