-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deathmatch: additional improvements #522
deathmatch: additional improvements #522
Conversation
Use generic even/function names, use onPlayerResourceStart event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good
Is it about ready for review, @jlillis ? |
I had a few other things to add and one last round of clean up in mind. Hoping to have some free time this weekend to wrap up. |
Going to call this ready for review now. Would be nice to see it play-tested with more than myself and a VM to make sure everything works. |
I don't see any problems, but due to how niche "deathmatch" is, there is no better way to actually have it playtested than to put it out there. So merging the PR, to be subject to bug reports/addendums by later suggestion. |
This PR makes additional improvements to the new
deathmatch
resource:mapcycler
isn't running