Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin2: Added content for "Users" sub-tab in the "Rights" tab #445

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Aug 10, 2023

This PR add content for "Users" sub tab in the "Rights" tab.

image

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but two minor issues:
1 - PR fails lint checks
2 - Maybe add a confirmation box (messageBox) when removing a user?

Feel free to put the rest of your work on this ACL tab in this PR if you want.

@FileEX
Copy link
Contributor Author

FileEX commented Aug 14, 2023

Looks good overall, but two minor issues: 1 - PR fails lint checks 2 - Maybe add a confirmation box (messageBox) when removing a user?

Fixed issues and update texts and added a confirmation window

Feel free to put the rest of your work on this ACL tab in this PR if you want.

I asked a few people on discord and they all answered me unequivocally that I should create a separate PR for each tab. I'd rather be safe and send the tabs as a separate PR than make all the tabs as one PR and then edit and split it all up because someone else won't like it. I will be working on more sub-tabs, but will post them in separate PRs

@Dutchman101 Dutchman101 merged commit 3f8ecca into multitheftauto:master Aug 25, 2023
1 check passed
@FileEX FileEX deleted the admin2/rightstab/users branch April 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants