helpmanager: removed redundant invisible window #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's invisible at all times and leaves you confused if you accidentally click it which brings it to front and therefore makes any other gui elements seem unresponsive
|
I think it was intended to ensure the helpmanager was "AlwaysOnTop" - I've used the same trick before I know about the CEGUI property that does the same thing. Not sure why it needs to be always on top. If nobody else can think of a reason I think this is good to merge. |
jlillis
approved these changes
Jul 8, 2023
|
I see. In its current state however, if you were to click it, it would prevent any sort of interaction with the helpmanager itself as well up until you close and re-open it. Additionally, if you know this window exists (or by pure chance) you can move the window out of the way, so it's not fool-proof either. I'm definitely in favor of removing it, but if we want it to stay, we need to fix the annoyances it currently causes. Or just use the always on top property instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's empty, invisible at all times and leaves you confused if you accidentally click it which brings it to front and therefore makes any other gui elements underneath seem unresponsive. I can't think of what purpose this thing might have (had).