Fix #472 setElementHealth in onClientPedDamage can cause crash #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TracerDS
approved these changes
Nov 3, 2024
TheNormalnij
reviewed
Nov 5, 2024
| @@ -4394,12 +4394,10 @@ bool CClientGame::ApplyPedDamageFromGame(eWeaponType weaponUsed, float fDamage, | |||
| return false; | |||
| } | |||
|
|
|||
| if (pDamagedPed->IsLocalPlayer()) | |||
There was a problem hiding this comment.
Wasn't this check added to avoid possible desync issues?
There was a problem hiding this comment.
I don't think so, since HP will be synchronized when using setElementHealth in onClientPedDamage
There was a problem hiding this comment.
HP is synchronized, but a remote player can die locally. It can cause nasty issues potentially
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
The crash was caused by the fact that for peds other than the local player, the current HP value wasn’t being updated. As a result, the code tried to kill a ped who still had 1 HP, which, due to an invalid pointer, caused a crash. However, this leads to another side effect: due to the ped being recreated, the ped pointer becomes invalid, so the ped never dies with such code.
For the local player, it works differently, and the player dies normally. For other players, they’re likely immortal in the same way as non-player peds but i'm not sure.
In any case, recreating the ped in setElementHealth causes a chain of additional bugs and unexpected behaviors. This PR aims to eliminate the crash but doesn’t address the underlying issue with ped recreation