Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped the order of Hotring Racer 2 (ID: 502, model: hotrina) and Hotring Racer 3 (ID: 503, model: hotrinb) #3797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpeedyFolf
Copy link

Swapped the order of Hotring Racer 2 (ID: 502, model: hotrina) and Hotring Racer 3 (ID: 503, model: hotrinb) in /mods/deathmatch/logic/CVehicleNames.cpp

Currently when something (such as map editor, race vehiclechange pickup labels, and admin panel) use the function getVehicleNameFromModel, they're reversed from what you'd expect based on their ID, model name, and the vehicles list wiki page. This fixes that.

Before you go ahead and create a pull request, please make sure:

If your work is incomplete, do not prefix your pull request with "WIP", instead
create a draft pull request: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Thank you!

@SpeedyFolf
Copy link
Author

Not sure if it's intentionally been kept wrong.

Also not sure if the discrepancy between the 2 lists on line 206 is intentional or not. {"Sadler Damaged", "Sadler"}, in Server vs. {"Sadler", "Sadler Damaged"}, in Client.

@TheNormalnij TheNormalnij added the backwards-incompatible Should be merged after the release of 1.6.1 label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Should be merged after the release of 1.6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants