Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++20 support for Client #3636

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Add C++20 support for Client #3636

wants to merge 49 commits into from

Conversation

G-Moris
Copy link
Contributor

@G-Moris G-Moris commented Aug 9, 2024

С++20 for Client, my test version

TracerDS
TracerDS suggested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@TracerDS TracerDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to introduce C++20 for Client but you change server code?
You also didnt tackle any issues regarding game_sa and multiplayer_sa

Client/core/CCommands.cpp Outdated Show resolved Hide resolved
Client/core/CCommands.cpp Outdated Show resolved Hide resolved
Client/core/CCore.cpp Outdated Show resolved Hide resolved
Client/core/CCore.cpp Outdated Show resolved Hide resolved
Client/core/CEntryHistory.h Show resolved Hide resolved
Server/launcher/premake5.lua Outdated Show resolved Hide resolved
Server/mods/deathmatch/premake5.lua Outdated Show resolved Hide resolved
Shared/sdk/SharedUtil.Logging.hpp Outdated Show resolved Hide resolved
Shared/sdk/SString.h Show resolved Hide resolved
vendor/sparsehash/src/sparsehash/internal/hashtable-common.h Outdated Show resolved Hide resolved
TracerDS
TracerDS reviewed Aug 9, 2024
View reviewed changes
Client/core/CCommands.cpp Outdated Show resolved Hide resolved
tederis
tederis requested changes Aug 10, 2024
View reviewed changes
Client/core/CCommands.cpp Outdated Show resolved Hide resolved
Client/core/CCore.cpp Outdated Show resolved Hide resolved
Client/core/CVersionUpdater.Util.hpp Outdated Show resolved Hide resolved
@G-Moris G-Moris requested a review from tederis August 15, 2024 16:19
botder
botder requested changes Aug 23, 2024
View reviewed changes
Client/core/CCommands.cpp Outdated Show resolved Hide resolved
Client/core/CCommands.cpp Outdated Show resolved Hide resolved
Client/core/ServerBrowser/CServerBrowser.cpp Outdated Show resolved Hide resolved
Client/core/ServerBrowser/CServerBrowser.cpp Outdated Show resolved Hide resolved
Client/game_sa/CWeaponSA.cpp Outdated Show resolved Hide resolved
Shared/sdk/SString.h Show resolved Hide resolved
Shared/sdk/SharedUtil.Win32Utf8FileHooks.hpp Outdated Show resolved Hide resolved
@G-Moris
Copy link
Contributor Author

G-Moris commented Aug 25, 2024

@botder @tederis Do my corrections fit your requirements?

@G-Moris G-Moris requested a review from botder August 28, 2024 18:12
@G-Moris
Copy link
Contributor Author

G-Moris commented Aug 31, 2024 •
edited
Loading

@Dutchman101 Hello! Sorry for the trouble and for the fact that this is not on the topic of PR, can you please unblock me in the Multi Theft Development group? I'm not going to bother anyone or prescribe something bad. It's just that in some developments I want to work together with those who want it.

@G-Moris
Copy link
Contributor Author

G-Moris commented Sep 6, 2024

You want to introduce C++20 for Client but you change server code? You also didnt tackle any issues regarding game_sa and multiplayer_sa

Maybe I'll try to solve it

@G-Moris G-Moris changed the title С++20 for Client Add C++20 support for Client Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis Awaiting requested review from tederis

@TracerDS TracerDS Awaiting requested review from TracerDS

@botder botder Awaiting requested review from botder

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@G-Moris @tederis @botder @TracerDS @Moris-Onz