Support encoding in parallel and partial flush - WIP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posrabi
commented
Apr 26, 2022
Posrabi
commented
- Add SetFirst, SetArray to allow using multiple stream encoder at once.
- Flush the buf when its contents reach 64 kB ( needs more testing to find the most suitable number).
- Do not enclose the array if the array field is set to false.
eatonphil
reviewed
Apr 26, 2022
eatonphil
reviewed
Apr 26, 2022
| return sw | ||
| } | ||
|
|
||
| func (sw *StreamEncoder) SetArray(array bool) *StreamEncoder { |
There was a problem hiding this comment.
This can be in the constructor rather than here, right?
There was a problem hiding this comment.
Actually I don't think so, I am doing this so I could override the default encoder settings here.
https://github.com/multiprocessio/datastation/blob/9de174a0a88d5623bfedf74601cd13a67c1e6f90/runner/file.go#L34
eatonphil
reviewed
Apr 26, 2022
| @@ -32,8 +32,20 @@ func NewGenericStreamEncoder(w io.Writer, marshalFn Marshaler, array bool) *Stre | |||
| } | |||
| } | |||
|
|
|||
| func (sw *StreamEncoder) SetFirst(first bool) *StreamEncoder { | |||
| sw.first = first | |||
There was a problem hiding this comment.
This needs to be surrounded with a mutex if this is modified by EncodeRow
There was a problem hiding this comment.
I'm only using it on initializing.
eatonphil
reviewed
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.