Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: daily validation of the ELL compatibility #308

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

matttbe
Copy link
Member

@matttbe matttbe commented Oct 24, 2024

We recently had some issues because the ELL API has been broken without notice.

Simply adding a cron to run the tests once a day during the week should tell us when an incompatible change has been introduced on ELL side, so we can get a bit of time to prepare a fix and a new release.

While at it, also switch to newer versions of some deprecated GH actions.

We recently had some issues because the ELL API has been broken without
notice.

Simply adding a cron to run the tests once a day during the week should
tell us when an incompatible change has been introduced on ELL side, so
we can get a bit of time to prepare a fix and a new release.

Link: multipath-tcp#302
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
The previous version is deprecated, each job gets this warning:

  The following actions uses node12 which is deprecated and will be
  forced to run on node16: actions/checkout@v2. For more info:
  https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

No further changes needed: we use the public runners with ubuntu-latest.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
The previous version is deprecated, each job using it gets this warning:

  The following actions uses a deprecated Node.js version and will be
  forced to run on node20: coverallsapp/github-action@master. For more
  info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

We just have to use 'file' instead of 'path-to-lcov' which is
deprecated. No further changes needed: we use the public runners with
ubuntu-latest.

Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11502994362

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.799%

Totals Coverage Status
Change from base Build 10861100461: 0.0%
Covered Lines: 1399
Relevant Lines: 2159

💛 - Coveralls

@matttbe
Copy link
Member Author

matttbe commented Oct 24, 2024

I don't think any reviews are needed here: just some simple modifications of the CI config, the behaviour is not supposed to be modified, only one new trigger.

@matttbe matttbe merged commit 269f10a into multipath-tcp:main Oct 24, 2024
6 checks passed
@matttbe matttbe deleted the ci-daily-ell-dev branch October 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants