handle timeouts using i/o deadlines. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both initiator and responder now time out if reads and/or writes are blocked for 30 seconds (default negotiation timeout). Introduces two tests to validate the new behaviour. Fixes #47.
vyzo
approved these changes
Nov 1, 2019
|
This fails CI because of libp2p/go-libp2p#736. |
Stebalien
reviewed
Nov 2, 2019
There was a problem hiding this comment.
Note: IMO, the real issue is libp2p/go-libp2p#738.
(although canceling here as well is probably a good idea anyways)
| } | ||
| if err2 != nil { | ||
| return err2 | ||
| if clearFn, err := setDeadline(rwc); err != nil { |
There was a problem hiding this comment.
So, many connections implement net.Conn (and SetDeadline) but don't actually implement it (and instead return an error). This is why we do things like https://github.com/libp2p/go-libp2p-transport-upgrader/blob/0d4065ec7151149beef41f3a8b1fbf6978ed12dc/upgrader.go#L111-L132.
There was a problem hiding this comment.
Note: we could detect and handle os.ErrNoDeadline.
| "time" | ||
| ) | ||
|
|
||
| // NegotiationTimeout is the maximum time a protocol negotiation atempt is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both initiator and responder now time out if reads and/or writes are blocked for 30 seconds (default negotiation timeout).
Introduces two tests to validate the new behaviour.
Fixes #47.
Addresses filecoin-project/lotus#518.