Remove cargo audit workflow #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We realized that libraries should probably not check for CVEs. It will generate too many false positives and provide very little value. It's up to downstream *program* developers to select exact versions of transitive dependencies. If it ends up being that no version of one of our dependencies is safe/works, then that program developer must report to this library that we should probably consider upgrading/replacing that dependency with something better.
faern
force-pushed
the
remove-cargo-audit-ci
branch
from
b1d36fa to
8066e8d
Compare
hulthe
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realized that libraries should probably not check for CVEs. It will generate too many false positives and provide very little value. It's up to downstream program developers to select exact versions of transitive dependencies. If it ends up being that no version of one of our dependencies is safe/works, then that program developer must report to this library that we should probably consider upgrading/replacing that dependency with something better.
We did the same to nftnl-rs a while ago: mullvad/nftnl-rs@00c3dd8. And I went ahead and did it here now since the audit CI job has been failing every night for quite a while now: https://github.com/mullvad/pfctl-rs/actions/runs/13323810221/job/37213003192
This change is