Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position location marker on the map correctly ios 993 #7478

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Jan 17, 2025

This PR deletes the SwiftUI spinner view and retvrns to tradition by re-introducing SpinnerActivityIndicatorView into TunnelViewController.

Additionally, the map and spinner will be centered higher on the map so it doesn't get obscured by the newly introduced ConnectionView written in SwiftUI.
The spinner position varies slightly based on the available screen estate, typically, it will be positioned higher on devices with less than 700 pixels in height.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Jan 17, 2025
@buggmagnet buggmagnet self-assigned this Jan 17, 2025
Copy link

linear bot commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant