When phone loses connectivity it fails to reconnect ios 889 #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
force-pushed
the
when-phone-loses-connectivity-it-fails-to-reconnect-ios-889
branch
from
0c6409d
to
3b8bc2e
Compare
pinkisemils
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 5 of 6 files at r2, all commit messages.
Reviewable status: 9 of 11 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
when-phone-loses-connectivity-it-fails-to-reconnect-ios-889
branch
from
ea064ff
to
8ae4da2
Compare
pinkisemils
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 5 of 6 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
when-phone-loses-connectivity-it-fails-to-reconnect-ios-889
branch
from
8ae4da2
to
7f84b85
Compare
buggmagnet
deleted the
when-phone-loses-connectivity-it-fails-to-reconnect-ios-889
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the concept of opening and closing a socket for pinging the gateway address, that functionality has been moved into WireGuardKit.
Which address to ping is now passed via the
ConfigurationBuildermullvad-masterbranch instead.This change is