Fix the cached relays to include daita information in new app version #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved
rablador
previously approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
infer-whether-the-cached-relays-file-has-daita-enabled-and-ios-811
branch
from
77d93c2
to
dd36b8d
Compare
rablador
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
infer-whether-the-cached-relays-file-has-daita-enabled-and-ios-811
branch
from
dd36b8d
to
1afb6ad
Compare
buggmagnet
deleted the
infer-whether-the-cached-relays-file-has-daita-enabled-and-ios-811
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem with old installs not having daita information in cache when upgrading to a new version.
How to test
2024.5or earlierWhat is expected
This change is