-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update connection details on main view to indicate that DAITA is used #6719
Update connection details on main view to indicate that DAITA is used #6719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 56 files reviewed, 2 unresolved discussions (waiting on @rablador)
ios/MullvadVPN/View controllers/Tunnel/TunnelControlView.swift
line 239 at r1 (raw file):
if observedState.connectionState?.isDaitaEnabled == true { connectedRelayName += " using DAITA"
Should we use localised strings here ?
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
line 18 at r1 (raw file):
"location" : "https://github.com/mullvad/wireguard-apple.git", "state" : { "revision" : "fb9a34f15e47b167866af3257a8dcc9901d9e7c1"
Please remove this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 56 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/View controllers/Tunnel/TunnelControlView.swift
line 239 at r1 (raw file):
Previously, buggmagnet wrote…
Should we use localised strings here ?
Or rather, I think this should be the localised string instead of setting it below, since those work with lookup tables, we'd need a different localised string for every possible "relay name + using daita" combination, if you see what I mean
f370501
to
19103d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 56 files reviewed, 1 unresolved discussion
ios/MullvadVPN/View controllers/Tunnel/TunnelControlView.swift
line 239 at r1 (raw file):
Previously, buggmagnet wrote…
Or rather, I think this should be the localised string instead of setting it below, since those work with lookup tables, we'd need a different localised string for every possible "relay name + using daita" combination, if you see what I mean
I see indeed, however, we should come up with something more clever than simply adding the strings as they are. On desktop, the Swedish translation is grammatically wrong since it's directly translated. 😕
a687981
to
40fd83b
Compare
40fd83b
to
8d08e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 56 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
line 18 at r1 (raw file):
Previously, buggmagnet wrote…
Please remove this change
Done.
166e7ef
to
678f653
Compare
8d08e8c
to
97ffc00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 56 of 56 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
97ffc00
to
aab3dd7
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
When DAITA is being used, the main view should indicate as much.
The main view should be updated to follow desktop and add extra text to the relay line to indicate if DAITA is being used. For now, multihop and singlehop cases shouldn't be differentiated.
Whether DAITA is used or not should be inferred from the communication between the client and the packet tunnel.
This change is