Upgrade rustls related crates #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw
rustls-pemfilehad a significant version bump available. So I went ahead and upgraded it. Also saw that other rustls related crates (including rustls itself) had some semver incompatible upgrades available. So I went ahead and upgraded all of them.I usually check changelogs when doing semver incompatible upgrades. Sadly I have a hard time checking what changed in
tokio-rustlsdue to rustls/tokio-rustls#8. But I suppose it should be fine. I downloaded both packages from crates.io and compared the sources there. I did not immediately see anything sticking out.I have tried this upgrade on Linux, Windows and macOS quickly and the app seems to work.
This change is