W-17280936: Use SLF4J API instead of JUL #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eze210
changed the title
asanguinetti
previously approved these changes
Nov 26, 2024
Comment on lines
27
to
38
| private static boolean useSlf4j() { | ||
| if (isMuleLogSeparationEnabled) { | ||
| // When log separation is enabled, the isLogEnabled() methods are expensive, and then we would be adding a | ||
| // performance degradation. If the user still wants to use SLF4J, then they have to set the property | ||
| // org.mule.grizzly.useSLF4J=true | ||
| return useSlf4jProperty; | ||
| } else { | ||
| // If log separation is disabled, there is no evidence or known issues of a performance degradation caused | ||
| // by this change, so it's safe to use SLF4J. | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just a suggestion to give it a thought:
What if we make it so that isMuleLogSeparationEnabled affects the default of useSlf4jProperty? That way, it could be used as a kill switch with or without log separation, just in case. So, even if log separation is disabled, the user can still do org.mule.grizzly.useSLF4J=false if there is a problem.
There was a problem hiding this comment.
Done. Also changed the property name to mule.grizzly.useSLF4J
Comment on lines
67
to
70
| @Override | ||
| public void trace(String format, Object arg) { | ||
| julDelegate.log(Level.FINEST, new MessageSupplier(MessageFormatter.format(format, arg))); | ||
| } |
There was a problem hiding this comment.
Question here: the MessageFormatter.format does not do any actual formatting until getMessage is called?
asanguinetti
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.slf4j.org/apidocs/org/slf4j/bridge/SLF4JBridgeHandler.html
FINEST -> TRACE
FINER -> DEBUG
FINE -> DEBUG
INFO -> INFO
WARNING -> WARN
SEVERE -> ERROR