This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
Adding new template level ALS-1858 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
llibarona
reviewed
Feb 22, 2022
| @@ -173,7 +173,8 @@ | |||
| "enum": [ | |||
| "NONE", | |||
| "SIMPLE", | |||
| "FULL" | |||
| "FULL", | |||
| "BOTH" | |||
There was a problem hiding this comment.
como anda esto si no se movio la version de ALS?
There was a problem hiding this comment.
la prueba la hice localmente haciendo el assembly de ALS y usando el jar.
There was a problem hiding this comment.
Parece que nuestro ultimo release de la extension no esta usando ALS 5.1.0? (el branch de master tiene aun en el package.json el node client en 5.0.1)
Entiendo que a este pr le falta el bump de version y deberiamos sacar otra version de la extension?
Todo esto salto porque tenemos que chequear el cambio para APID (no vieron cambios y consultaron al respecto)
emilianoascona
force-pushed
the
fix-ALS-1858-template-levels
branch
from
72fd5a1 to
ea9e192
Compare
emilianoascona
force-pushed
the
fix-ALS-1858-template-levels
branch
from
ea9e192 to
d11e0d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.