-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support linemod params analysis #24
base: master
Are you sure you want to change the base?
support linemod params analysis #24
Conversation
@@ -1605,7 +1606,7 @@ pcl::LINEMOD::detectTemplatesSemiScaleInvariant ( | |||
} | |||
|
|||
detection.template_id = static_cast<int> (template_index); | |||
detection.score = score; | |||
detection.score = raw_score_rebased;//score; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the score the same, and add raw_score_rebased
member to detection. (why not also adding raw_score
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florisatmujin sure. But I was confused by these different scores and feel some redundancy. I wonder (through test) if it is possible to only use one kind of score.
#pragma omp critical | ||
{ | ||
scoresTemp.push_back(raw_score_rebased); | ||
indicesOfDetections.push_back(detection_index); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we store the score inside the LINEMODDetection
member?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florisatmujin evaluationScores
is evaluation score, it has nothing to do with the detection
support linemod params analysis