-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow theme switcher override with slots #4340
Allow theme switcher override with slots #4340
Conversation
… components & add custom theme switcher example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The demo and explanation of the slots
seems clear to me. Perhaps we can have a diagram eventually when we have more slots
Yeah, will kind of see how it evolves as we go, the new "Examples" section should help show some particular scenarios that might be useful. |
@bharatkashyap I just noticed this if you sign out in the "Account in sidebar" example: Probably no need to fix it in this release, just ran into it! Also not sure how to best handle it in the mini variant of the sidebar... |
Thanks for that catch! I'll open an issue to track this |
Closes #4151 and #4291
ThemeSwitcher
component intoolbarActions
slot so it can be hiddenThemeSwitcher
andToolbarActions
(default slot) componentsDashboardLayout
demo page in docshttps://deploy-preview-4340--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/#customization