[core] Allow changing the width of the drawer in dashboard layout com… #4296
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Looks great, thank you!
Can you also please autogenerate the documentation for the new prop?
You should be able to do it by running 2 scripts from the root package after addressing the comments below.
pnpm proptypespnpm docs:build:api
And then just add and commit the autogenerated changes!
| @@ -89,6 +89,10 @@ export interface DashboardLayoutProps { | |||
| * @default false | |||
| */ | |||
| hideNavigation?: boolean; | |||
| /** | |||
| * The width in pixel of the sidebar when expanded, default value is 320. | |||
There was a problem hiding this comment.
Suggested change
| * The width in pixel of the sidebar when expanded, default value is 320. | |
| * Width of the sidebar when expanded, in pixels. | |
| * @default 320 |
| @@ -286,7 +291,7 @@ function DashboardLayout(props: DashboardLayoutProps) { | |||
|
|
|||
| const getDrawerSharedSx = React.useCallback( | |||
There was a problem hiding this comment.
In this getDrawerSharedSx callback, sidebarExpandedWidth also needs to be added at the end to the dependencies array.
The react-hooks/exhaustive-deps eslint rule should automatically show you an error about this.
apedroferreira
added
component: DashboardLayout
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.