Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolpad Editor] Fix Markdown text alignment issue #2591

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

rohanprasadofficial
Copy link
Contributor

Fixes #2588

This PR targets to fix the alignment issues when rendering the markdown text component on the canvas. It was also showing the wrong alignment state on the left panel.

The typography was taking full width not allowing the text to align to correct position.

This is a similar issue to this : #2071

Before :

md.text.issue.mov

After :

md.text.issue.fixed.mov
  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature
  • I've linked relevant GitHub issue with "Closes #"
  • I've added a visual demonstration under the form of a screenshot or video

@bharatkashyap bharatkashyap added the bug 🐛 Something doesn't work label Aug 31, 2023
@bharatkashyap
Copy link
Member

Looks good to me! Thanks for the contribution @rohanprasadofficial

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 31, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2023
@Janpot
Copy link
Member

Janpot commented Sep 4, 2023

Looks good. Shall we add the same as #2587 (comment) but with three elements in markdown mode?

@rohanprasadofficial
Copy link
Contributor Author

@Janpot , yes i think we should add it here as well, will add the visual test and push in.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2023
@Janpot
Copy link
Member

Janpot commented Sep 5, 2023

Thank you!

@Janpot Janpot merged commit 16fc322 into mui:master Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal alignment not working for Markdown Text component
3 participants