-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support date/dateTime formatting #2589
Conversation
]), | ||
); | ||
|
||
const DEMO_DATE = new Date(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also be the current time? Anyway not important at all :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want a time that always demonstrates whether it's 12h or 24h clock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment
Just tried it, works great! |
You mean only having a |
Ok, if the X grid separates them I guess we should do the same. |
This PR proposes date formatting for the date and dateTime columns, in the flavour of the number formatter. Similarly it is built on top of
Intl.DateTimeFormat
and can be reused for other components just like we reuse the number format for the Metric componentFixes #2581
Screen.Recording.2023-08-31.at.11.10.21.mov
edit
Reversed the order since the video: