-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toolpad Editor] Fix : text component alignment rendering #2587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective, thank you!
Suggesting a possible improvement just in case it also works.
I'd think I'd like to add some visual regression tests before we merge this with
|
@Janpot is this configured internally or i can do that ? If yes can you point me to any docs for same ? |
I'm adding a test here. Once that one is merged we can add some tests for alignment as well. I don't know if you've noticed, but this PR causes a visual regression test to fail around resizing columns: https://app.argos-ci.com/mui/mui-toolpad/builds/668/56635162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes a regression in https://app.argos-ci.com/mui/mui-toolpad/builds/668/56635162
Oh, in the test |
I've added a PR for handle the visual test regression here: #2610 |
Can you just add a short text for each alignment in the visual regression tests? You can start them with
You can just drag three more text components to the bottom of this page and configure their alignment. The screenshot will update accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohanprasadofficial This PR broke the text loading indicator: #2631 |
Fixes #2071
This PR targets to fix the alignment issues when rendering the text component on the canvas. It was also showing the correct alignment state on the left panel.
The typography was taking full width not allowing the text to align to correct position.
Made the typography alignment as 'auto' to fix the issue.
After Fix
text.alignment.fix.mov