-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add React conf 2024 talk video #120
Open
mnajdova
wants to merge
11
commits into
mui:master
Choose a base branch
from
mnajdova:docs/add-video
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
reviewed
Jun 3, 2024
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Marija Najdova <[email protected]>
brijeshb42
approved these changes
Jun 17, 2024
danilo-leal
reviewed
Jun 17, 2024
@@ -9,6 +9,14 @@ Pigment CSS is a zero-runtime CSS-in-JS library that extracts the colocated sty | |||
|
|||
<div align="center"> | |||
|
|||
Check out Olivier Tassinari introducing Pigment CSS at React Conf 2024: | |||
|
|||
<a href="http://www.youtube.com/watch?feature=player_embedded&v=0ckOUBiuxVY&t=21677s" target="_blank"><img src="https://img.youtube.com/vi/0ckOUBiuxVY/0.jpg" alt="Introduction of Pigment CSS during React Conf 2024" style="width: 50%; height: 50%; aspect-ratio: 16/9;" /></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the image, though — the video's thumbnail is not super informative. How about just using it text to link to it? We may not need the image at all!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://github.com/mnajdova/pigment-css/tree/docs/add-video?tab=readme-ov-file
Based on mui/material-ui#42500