Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add a referenceDate prop on DateCalendar, MonthCalendar and YearCalendar #9260

Merged
merged 4 commits into from
Jun 13, 2023
Merged

[pickers] Add a referenceDate prop on DateCalendar, MonthCalendar and YearCalendar #9260

merged 4 commits into from
Jun 13, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 7, 2023 •
edited
Loading

Follow up on #9019
Closes #8852

I'd be in favor of waiting for all the components to support referenceDate before potentially documenting it.

Next steps

  • Add to the time view components
  • Add to the pickers (will allow to deprecate defaultCalendarMonth)

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Jun 7, 2023
@flaviendelangle flaviendelangle self-assigned this Jun 7, 2023
@mui-bot
Copy link

mui-bot commented Jun 7, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9260--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 606.8 1,264.9 606.8 913.64 235.083
Sort 100k rows ms 650.6 1,301 650.6 975.68 216.703
Select 100k rows ms 239.9 380.6 305.5 314.02 51.308
Deselect 100k rows ms 211.2 304.5 214.9 233.52 35.722

Generated by 🚫 dangerJS against d63c43d

@flaviendelangle flaviendelangle force-pushed the reference-date-calendars branch 2 times, most recently from c5fd9fc to 4982dc6 Compare June 9, 2023 08:14
@flaviendelangle flaviendelangle marked this pull request as ready for review June 9, 2023 08:34
LukasTy
LukasTy approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯 👍

packages/x-date-pickers/src/MonthCalendar/MonthCalendar.types.ts Show resolved Hide resolved
@flaviendelangle flaviendelangle merged commit 10a4f4a into mui:master Jun 13, 2023
@flaviendelangle flaviendelangle deleted the reference-date-calendars branch June 13, 2023 14:47
@flaviendelangle flaviendelangle mentioned this pull request Jun 20, 2023
Merged
@flaviendelangle flaviendelangle mentioned this pull request Mar 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Allow specifying the current year in <MonthCalendar />
3 participants
@flaviendelangle @mui-bot @LukasTy