-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Clean popper position on new pickers #7445
Conversation
These are the results for the performance tests:
|
567bcc6
to
da0485b
Compare
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels much better on my end in this demo https://deploy-preview-7445--material-ui-x.netlify.app/x/react-date-pickers/date-picker/#basic-usage 👌
Regarding the transition, something feels wrong, it doesn't feel great. Maybe no transitions would feel better or faster on or with an origin a bit more on the left side. Maybe it's only point 12 of #7440.
packages/x-date-pickers/src/internals/hooks/useDesktopPicker/useDesktopPicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx
Outdated
Show resolved
Hide resolved
23ceb71
to
bf2b0e5
Compare
packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/MultiInputDateRangeField/MultiInputDateRangeField.tsx
Outdated
Show resolved
Hide resolved
We can experiment with different transitions in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Very nice fine-tuning improvements. 👌
Part of #7440
This one changes the behavior compared to v5 so it's worth discussing
bottom-start
center
but addfullWidth
prop to theTextField
to make sure there is never space at the right of the last inputhttps://deploy-preview-7445--material-ui-x.netlify.app/x/react-date-pickers/date-picker/#basic-usage