[pickers] Clean the internals and the public API of <PickersPopper />
#16319
+218
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
flaviendelangle
force-pushed
the
pickers-popper-context
branch
2 times, most recently
from
dde1420 to
431d5d9
Compare
flaviendelangle
commented
Jan 24, 2025
| const themeProps = useThemeProps({ | ||
| props, | ||
| name, | ||
| }); | ||
| const reduceAnimations = useReduceAnimations(themeProps.reduceAnimations); |
There was a problem hiding this comment.
I unified the behavior of useReduceAnimations with usePickerOrientation it now takes the explicit value as a param.
|
Deploy preview: https://deploy-preview-16319--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
pickers-popper-context
branch
2 times, most recently
from
c150930 to
5e39ab6
Compare
flaviendelangle
commented
Jan 24, 2025
| * Whether the heavy animations should be disabled. | ||
| * @default `@media(prefers-reduced-motion: reduce)` || `navigator.userAgent` matches Android <10 or iOS <13 | ||
| */ | ||
| reduceAnimations?: boolean; |
There was a problem hiding this comment.
Not sure if we should name this one with a boolean prefix (shouldReduceAnimations for instance) or not.
I kept the name of the prop for now.
I added it to the public context because I think it's something people should be able to use, especially for custom views when we will stop drilling it to the view.
flaviendelangle
force-pushed
the
pickers-popper-context
branch
from
5e39ab6 to
d7a750c
Compare
flaviendelangle
changed the title
<PickersPopper /><PickersPopper />
flaviendelangle
changed the title
<PickersPopper /><PickersPopper />
flaviendelangle
force-pushed
the
pickers-popper-context
branch
from
d7a750c to
1e92a72
Compare
flaviendelangle
changed the title
<PickersPopper /><PickersPopper />
flaviendelangle
changed the title
<PickersPopper /><PickersPopper />
flaviendelangle
force-pushed
the
pickers-popper-context
branch
from
de9cd30 to
fcf345e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16175
PickersPopper=>PickerPopper