Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Experimental touch scroll lock #16313

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lauri865
Copy link
Contributor

@lauri865 lauri865 commented Jan 23, 2025

Hacky experiment to try to solve #11230

Best solution I've found to date (but does mean side-stepping native scroll and scroll properties altogether in favour of transform), but it still has many rough edges:

  • Breaks when switching between input devices
  • Doesn't support sticky bottom rows (easy fix)
  • Probably breaks with some apiRef methods, such as scrollToIndexes, etc.
  • Doesn't properly support overscroll (probably an easy fix though)

More context: #11230 (comment)

Preview on touch device (try scrolling diagonally, and switching directions quickly): https://deploy-preview-16313--material-ui-x.netlify.app/x/react-data-grid/#pro-version

@lauri865 lauri865 marked this pull request as draft January 23, 2025 14:00
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants