-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Revert apiRef
to be MutableRefObject
for React versions < 19
#16279
Conversation
Deploy preview: https://deploy-preview-16279--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 👍
Sorry for not testing thoroughly enough and thus not flagging this problem when working on the migration PR. 🙈
Well, you were not alone in that 😅 |
@cherniavskii just to confirm and give a context for other as well.
Or R19 for v7 should also have Update: Types matrix
|
@arminmeh For v8, either |
04da28e
to
d914b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Cherry-pick PRs will be created targeting branches: v7.x |
Closes #16135
Because I would like to cherry pick this to v7 I have left these two items for a follow-up PR that will be for v8 only
apiRef
beingnull
- [data grid] Improve typing foruseGridApiRef
#16000Results of these changes:
React 18
React 19
CC: @flaviendelangle @alexfauquette @LukasTy
We can extend this also to other packages