-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] improve scrollbar deadzone with overlay scrollbars #15961
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-15961--material-ui-x.netlify.app/ |
Fyi, about the case that makes the CI fail, sometimes those |
All the tests were passing when I first opened this PR. It's very unlikely that such a simple change would break any tests to begin with. Since then, merged master to the PR twice:
Seems unrelated to the nature of the change, so I don't feel like debugging the test system to be honest. |
Now there are 576 Argos changes 🫠 FWIW, all the unit tests are (still) passing locally, so I'm not sure how I could even debug the CI failure to begin with. |
The argos issue is present in all open PR:s, should be dealt with shortly. And if the other failure is a flaky test we'll ignore it and deal with it independently. |
On OS X and potentially other platforms that hide scrollbars when not scrolling, virtual scrollbars are effectively overlapping. When scrollbar is scrolled to the end, there's a dead zone where you cannot drag the scroll handle at all until you manually scroll it out of the dead zone, and scrolling works in only in one direction (whichever comes last in the DOM, currently horizontal scrollbar).
This PR adds two improvements: