Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add prop to override search input props in GridColumnsManagement #15347

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[DataGrid] Add prop to override search input props in GridColumnsManagement #15347

wants to merge 5 commits into from
+150 −72

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Nov 8, 2024 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Nov 8, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15347--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7611262

k-rajat19
k-rajat19 commented Nov 8, 2024
View reviewed changes
packages/x-data-grid/src/components/columnsManagement/GridColumnsManagement.tsx
@@ -228,6 +231,7 @@ function GridColumnsManagement(props: GridColumnsManagementProps) {
}}
fullWidth
{...rootProps.slotProps?.baseTextField}
{...searchInputProps}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping it below the text field slot props so that it overrides them as well?

Copy link
Contributor Author

@k-rajat19 k-rajat19 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KenanYusuf,
do you think we should make this a search input by default similar to in case of quick Filter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, search seems to be the correct input type here 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, tested changes here
https://deploy-preview-15347--material-ui-x.netlify.app/x/react-data-grid/column-visibility/

@k-rajat19 k-rajat19 marked this pull request as ready for review November 8, 2024 16:54
k-rajat19
k-rajat19 commented Nov 10, 2024
View reviewed changes
packages/x-data-grid/src/components/columnsManagement/GridColumnsManagement.tsx
}}
autoComplete="off"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to get rid of suggestions
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#html.elements.input.autocomplete

k-rajat19
k-rajat19 commented Nov 10, 2024
View reviewed changes
packages/x-data-grid/src/components/columnsManagement/GridColumnsManagement.tsx
visibility: 'hidden',
},
]}
tabIndex={-1}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align with #14587

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
4 participants
@k-rajat19 @mui-bot @KenanYusuf @zannager