Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix scrolling performance when rowHeight={undefined} #14983

Merged
merged 5 commits into from
Oct 15, 2024
Merged

[DataGridPro] Fix scrolling performance when rowHeight={undefined} #14983

merged 5 commits into from
Oct 15, 2024

Conversation

cherniavskii
Copy link
Member

Fixes #14981

@cherniavskii cherniavskii added bug 🐛 Something doesn't work performance component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels Oct 15, 2024
@mui-bot
Copy link

mui-bot commented Oct 15, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14983--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e3ebadd

romgrk
romgrk reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with some of my changes in #14929 but I like the changes here better than mine, merge it when it's ready I'll incorporate them in my PR.

@cherniavskii cherniavskii marked this pull request as ready for review October 15, 2024 21:19
@romgrk romgrk merged commit 78cb399 into mui:master Oct 15, 2024
18 checks passed
@cherniavskii cherniavskii deleted the rowHeight-undefined branch October 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! performance plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGridPro] Poor scrolling performance with rowHeight={undefined}
3 participants
@cherniavskii @mui-bot @romgrk