[pickers] Create the new picker's ownerState object
#14889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
flaviendelangle
force-pushed
the
ownerState-picker
branch
from
baa73e9
to
71b017c
Compare
|
Deploy preview: https://deploy-preview-14889--material-ui-x.netlify.app/ |
flaviendelangle
commented
Oct 9, 2024
| @@ -14,3 +14,22 @@ export interface PickerValidDateLookup {} | |||
| export type PickerValidDate = keyof PickerValidDateLookup extends number | |||
| ? any | |||
| : PickerValidDateLookup[keyof PickerValidDateLookup]; | |||
|
|
|||
| export interface PickerOwnerState<TValue> { | |||
There was a problem hiding this comment.
I would be in favor of keeping the object as minimal as possible for now and add more properties as user request them.
But if you have another property that you think is important, I can of course add it 👍
There was a problem hiding this comment.
It's a very good candidate for the ownerState indeed 👌
I propose to treat it in a follow up, because I'm not sure we want to have it in its current shape.
We discussed following MD3 nomenclature (docked and modal) instead of mobile and desktop and this would impact the name of this property.
5 tasks
flaviendelangle
changed the title
ownerState objectownerState object
flaviendelangle
requested review from
LukasTy,
michelengelen,
arthurbalduini and
noraleonte
arthurbalduini
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14475
No breaking change, we can merge it before the alpha.
PickerOwnerStateinterface and create theownerStateinusePickerownerStatefromusePickerfor theopenPickerIconslot which already uses a small object