-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Cleanup of the Tree View demos #13237
Merged
flaviendelangle
merged 4 commits into
mui:master
from
flaviendelangle:clean-doc-tree-view
May 30, 2024
Merged
[docs] Cleanup of the Tree View demos #13237
flaviendelangle
merged 4 commits into
mui:master
from
flaviendelangle:clean-doc-tree-view
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
Improvements or additions to the documentation
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
labels
May 24, 2024
This was referenced May 24, 2024
Deploy preview: https://deploy-preview-13237--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
clean-doc-tree-view
branch
from
May 24, 2024 09:32
72fdb3d
to
41825a9
Compare
arthurbalduini
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
noraleonte
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements 🎉
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI_X_PRODUCTS
dataset whenever a data change is not relevant (even for basic customization examples)RichTreeView
in theSimpleTreeView
doc, ...)slotProps
on theRichTreeView
that did not reflect the demoaria-label
, IMHO either we always use it and with a meaningful title or we never use itRegarding the
MUI_X_PRODUCTS
, the issue is that we loose the preview onSimpleTreeView
because the dataset is too big.Do you think we should find a smaller dataset (having a small dataset on some demos and a larger on others make no sense IMHO, it's hard to have the right dimensions when it varies across demos and a lot of demos where the preview could be useful don't have one)?
Preview: https://deploy-preview-13237--material-ui-x.netlify.app/x/react-tree-view/