Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve French (fr-FR) locale #12755

Merged
merged 3 commits into from
Apr 12, 2024
Merged

[l10n] Improve French (fr-FR) locale #12755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d6131b
Added missing French data-chart locales keys
derek-0000 Apr 11, 2024
7870500
Updated frFR data-grid locales
derek-0000 Apr 11, 2024
97d84f7
Update packages/x-data-grid/src/locales/frFR.ts
flaviendelangle Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/data-grid/localization/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"languageTag": "fr-FR",
"importName": "frFR",
"localeName": "French",
"missingKeysCount": 3,
"missingKeysCount": 0,
"totalKeysCount": 117,
"githubLink": "https://github.com/mui/mui-x/blob/master/packages/x-data-grid/src/locales/frFR.ts"
},
Expand Down
10 changes: 5 additions & 5 deletions packages/x-data-grid/src/locales/frFR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const frFRGrid: Partial<GridLocaleText> = {
// Filters toolbar button text
toolbarFilters: 'Filtres',
toolbarFiltersLabel: 'Afficher les filtres',
toolbarFiltersTooltipHide: 'Cacher les filtres',
toolbarFiltersTooltipHide: 'Masquer les filtres',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me.
But it would be interesting to double-check with @flaviendelangle or @alexfauquette 🤞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it's more professional

toolbarFiltersTooltipShow: 'Afficher les filtres',
toolbarFiltersTooltipActive: (count) =>
count > 1 ? `${count} filtres actifs` : `${count} filtre actif`,
Expand All @@ -39,9 +39,9 @@ const frFRGrid: Partial<GridLocaleText> = {
toolbarExportExcel: 'Télécharger pour Excel',

// Columns management text
// columnsManagementSearchTitle: 'Search',
// columnsManagementNoColumns: 'No columns',
// columnsManagementShowHideAllText: 'Show/Hide All',
columnsManagementSearchTitle: 'Rechercher',
columnsManagementNoColumns: 'Pas de colonnes',
columnsManagementShowHideAllText: 'Afficher/masquer toutes',

// Filter panel text
filterPanelAddFilter: 'Ajouter un filtre',
Expand Down Expand Up @@ -107,7 +107,7 @@ const frFRGrid: Partial<GridLocaleText> = {
columnMenuShowColumns: 'Afficher les colonnes',
columnMenuManageColumns: 'Gérer les colonnes',
columnMenuFilter: 'Filtrer',
columnMenuHideColumn: 'Cacher',
columnMenuHideColumn: 'Masquer',
columnMenuUnsort: 'Annuler le tri',
columnMenuSortAsc: 'Tri ascendant',
columnMenuSortDesc: 'Tri descendant',
Expand Down
Loading